Updated tab styling - #3351
Conversation
|
Pull request environment is available at https://stoctodocspr3351.z22.web.core.windows.net. You can view the ephemeral environment status in Octopus Deploy. This environment will be automatically deprovisioned when the pull request is closed, or after 7 days of inactivity. |
rosslovas
left a comment
rosslovas
left a comment
There was a problem hiding this comment.
Brilliant, that had been bugging me too! Looks so much better, and changes all look reasonable, I just spotted a few odd things. Ready to approve if you think none of these are worth addressing, just let me know; I only held off cause I noticed this was on auto-merge, just in case you did want to change anything 🙂
I'm also not sure we have anywhere that actually exercises this, but I tested it and found that too many tabs will overflow now instead of resulting in another row as they used to. Not sure how much that matters but thought I'd point it out regardless.
Before:
After:
- Removed tab-specific focus state and instead updated site-wide focus state - Made tab list overflow on x-axis to account for long many and long titles - Removed unnecessary :is() section
Had to add the tab-list focus state back because it was being cut off by the overflow
|
@rosslovas Thank you for catching 🙇 It now overflows on the x-axis when there are many / long tab titles 🙂 I also updated the site-wide focus styling so it's now styled consistently, but still needed to include tab-list specific styling because it was being cut off by the new overflow. |
3 participants
Summary
This is a tab styling fix.
Before and after
Bonus: Added a proper focus state